Perf: batch block list settings in single action #61329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +34 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
|
@jsnajdr Curious what you think about this :) |
jsnajdr
approved these changes
May 13, 2024
There was a problem hiding this comment.
This is good, but I think we don't really need the new private action. The existing updateBlockListSettings action could have both non-batch and batch forms:
updateBlockListSettings( clientId, settings );
updateBlockListSettings( clientId, null ); // delete
updateBlockListSettings( {
[ clientId1 ]: settings1,
[ clientId2 ]: null,
} );There is prior art for this (like passing a block object or an array of blocks) and it's easily typable with TypeScript, too.
ellatrix
force-pushed
the
try/batch-update-block-list-settings
branch
from
364180c to
a76d713
Compare
ellatrix
requested review from
ajitbohra,
ryanwelcher,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
ellatrix
force-pushed
the
try/batch-update-block-list-settings
branch
from
0ac0409 to
3a230b3
Compare
|
Flaky tests detected in 3a230b3. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9174057935
|
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jun 4, 2024
Co-authored-by: ellatrix <ellatrix@git.wordpress.org> Co-authored-by: jsnajdr <jsnajdr@git.wordpress.org>
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
Co-authored-by: ellatrix <ellatrix@git.wordpress.org> Co-authored-by: jsnajdr <jsnajdr@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Instead of reducing the store hundreds of times when updating with the initial block list settings, we could be combining them all into a single action.
Why?
In my testing this reduces the update from ~60-70ms to ~4-5ms.
The load perf test contains many, many things, so I don't expect a huge difference from a 60ms change. Still worth doing imo.Actually the first block metric seems to be down a bit:
Post editor: -5.37%, 0.29%, -5.37% (yes, twice exactly the same)
Site editor: -2.30%, -6.78%, -1.66%
How?
Testing Instructions
All tests should pass.
Testing Instructions for Keyboard
Screenshots or screencast